Skip to content

Conversation

@AtR1an
Copy link
Contributor

@AtR1an AtR1an commented Jan 22, 2026

No description provided.

@AtR1an AtR1an requested a review from a team as a code owner January 22, 2026 14:46
@AtR1an AtR1an requested review from Copilot and knime-ghub-bot and removed request for a team January 22, 2026 14:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the TargetObjectsPerInputRow.One enum value to TargetObjectsPerInputRow.Single to improve naming consistency and clarity in the structured output configuration.

Changes:

  • Renamed enum value from One to Single in the TargetObjectsPerInputRow enum class
  • Updated all test references to use the new Single enum value name
  • Updated the default value parameter to use Single instead of One

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/models/structured_output.py Renamed the One enum value to Single in TargetObjectsPerInputRow and updated the default parameter value
tests/test_structured_output.py Updated all test cases to reference TargetObjectsPerInputRow.Single instead of TargetObjectsPerInputRow.One

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AtR1an AtR1an force-pushed the enh/AP-25288-unify-naming branch from 760cd5e to 06b2931 Compare January 26, 2026 17:35
Copilot AI review requested due to automatic review settings January 26, 2026 17:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AtR1an AtR1an force-pushed the enh/AP-25288-unify-naming branch from f1bd228 to a4da211 Compare January 26, 2026 18:02
@AtR1an
Copy link
Contributor Author

AtR1an commented Jan 26, 2026

I ran the respective tests locally since the build system currently fails to execute tests and tomorrow is code freeze.

@AtR1an AtR1an merged commit fee753a into master Jan 26, 2026
1 check failed
@AtR1an AtR1an deleted the enh/AP-25288-unify-naming branch January 26, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants