Skip to content

Conversation

@AtR1an
Copy link
Contributor

@AtR1an AtR1an commented Jan 26, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 26, 2026 00:36
@AtR1an AtR1an requested a review from a team as a code owner January 26, 2026 00:36
@AtR1an AtR1an requested review from knime-ghub-bot and removed request for a team January 26, 2026 00:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates multiple dependencies in the project, particularly transitioning from older LangChain packages to newer versions and package structures.

Changes:

  • Migration from langchain to langchain-classic for legacy agent and chain components
  • Switch from langchain-google-vertexai to langchain-google-genai for Google model integrations
  • Update to Python 3.13 and comprehensive dependency version updates in pixi.toml

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/tools/vectorstore.py Updates imports to use langchain_classic for retrieval chains
src/models/google/_port_types.py Switches from Vertex AI to Google Generative AI SDK with updated parameter names
src/models/_adapter.py Changes LLM invocation method from direct call to .invoke()
src/indexes/chroma.py Simplifies Chroma vectorstore handling logic
src/eval/giskard/giskard_patch.py Adds monkey-patch for scipy compatibility with Giskard
src/eval/giskard/init.py Imports the new giskard_patch module
src/agents/openai.py Updates import to use langchain_classic
src/agents/base_deprecated.py Moves imports to local scope and adds ToolNode usage
src/agents/base.py Updates agent execution to use langchain_classic.agents.AgentExecutor and adds ToolNode
src/agents/_tool.py Switches from langchain.tools to langchain_core.tools
pixi.toml Major dependency reorganization with Python 3.13 upgrade and version updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +441 to +442
validate_ai_message,
LANGGRAPH_RECURSION_MESSAGE,
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in the import statement. The closing parenthesis should align with the opening line or the imported items should be consistently indented.

Suggested change
validate_ai_message,
LANGGRAPH_RECURSION_MESSAGE,
validate_ai_message,
LANGGRAPH_RECURSION_MESSAGE,

Copilot uses AI. Check for mistakes.
pixi.toml Outdated

[pypi-options]
no-build = true
# no-build = true
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out configuration should either be removed or include a comment explaining why it's disabled and under what circumstances it should be re-enabled.

Suggested change
# no-build = true
# no-build = true # Disabled to allow building packages from source during local development; re-enable in CI for reproducible binary-only builds.

Copilot uses AI. Check for mistakes.
pixi.toml Outdated
python = "3.13.*" # Runtime: Python 3.13
knime-extension = "5.8.*" # Framework: KNIME Python integration
knime-python-base = "*" # Framework: KNIME base libraries
# knime-python-versions = "5.8.*"
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out dependency should either be removed or include a comment explaining why it's disabled and when it should be re-enabled.

Suggested change
# knime-python-versions = "5.8.*"
# knime-python-versions = "5.8.*" # Disabled: only needed for multi-runtime KNIME setups; re-enable if/when multiple Python versions must be supported

Copilot uses AI. Check for mistakes.
@AtR1an AtR1an force-pushed the todo/AP-25545-update-deps branch from 2b561f7 to 9520191 Compare January 26, 2026 00:47
Copilot AI review requested due to automatic review settings January 26, 2026 16:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

max_retries=2, # default is 6, instead we just try twice before failing
base_url=self.custom_base_api_url or self.base_api_url,
credentials=google_credentials,
task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after '#' in comment.

Suggested change
task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings
task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 27, 2026 09:36
@marc-lehner marc-lehner force-pushed the todo/AP-25545-update-deps branch from 4cf2a2d to 6a4a163 Compare January 27, 2026 09:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marc-lehner marc-lehner force-pushed the todo/AP-25545-update-deps branch from 6a4a163 to e216fa0 Compare January 27, 2026 09:50
Copilot AI review requested due to automatic review settings January 27, 2026 13:22
@marc-lehner marc-lehner force-pushed the todo/AP-25545-update-deps branch from e216fa0 to 8f521fb Compare January 27, 2026 13:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marc-lehner marc-lehner force-pushed the todo/AP-25545-update-deps branch from 8f521fb to 11b6898 Compare January 27, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants