-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Feat: cilium routing mode setting #12588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tico88612
wants to merge
1
commit into
kubernetes-sigs:master
Choose a base branch
from
tico88612:feat/cilium-routing-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
cilium_routing_modeisnative, we should skiproutingMode: {{ cilium_routing_mode }}entirely, otherwise, cilium complains.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this should be allowed here and should be passed directly to cilium, for example if cilium introduce a new feature or something like that we can't handle, I think keeping this simple is a better approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayoubfaouzi Why? If you skip this, that's not working.
routingModedefault is tunnel.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, what I wanted to say was, when I deployed kubespray with cilium as CNI, I want to use native routing mode, so no tunneling. I modified
cilium_tunnel_modetodisabledas in the doc.However cilium kept complaining about
disabled, looks like it did not get it (should be only vxlan or geneve), so I had to edit the cm and completely get rid ofcilium_tunnel_modeand addrouting-mode: native.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe you try an empty string? the cilium docs said
cilium_tunnel_modeonly accepted"","vxlan","geneve"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am on same boat. cilium_tunnel_mode only accept vxlan or geneve. I tried empty string which started throwing errors.
For now I just kept tunnel-protocol to vxlan. Hope its acceptable value with routing mode native.