Skip to content

Conversation

@NarayanaSabari
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Add the TrainJob column to the “Job-integrated features” table on the Overview page and mark the features implemented by TrainJob with +. This update keeps documentation synchronized with the current TrainJob integration implemented in the codebase.

Which issue(s) this PR fixes:

Fixes #7864

Special notes for your reviewer:

  • This is a documentation-only change: site/content/en/docs/overview/_index.md.
  • Verified that TrainJob integration is implemented and covered by tests; references:
    • Partial admission / RunWithPodSetsInfo: pkg/controller/jobs/trainjob/trainjob_controller.go#L245-286
    • All-or-nothing (PodsReady): pkg/controller/jobs/trainjob/trainjob_controller.go#L335-350
    • Dynamic reclaim (ReclaimablePods): pkg/controller/jobs/trainjob/trainjob_controller.go#L352-376
    • MultiKueue integration adapters: pkg/controller/jobs/trainjob/trainjob_multikueue_adapter.go#L44-88, #L104-115
    • Webhook defaulting & validation (TAS): pkg/controller/jobs/trainjob/trainjob_webhook.go#L69-90, #L145-160
    • Manager config includes trainer.kubeflow.org/trainjob: config/components/manager/controller_manager_config.yaml#L56-60
    • Test coverage examples:
      • test/e2e/singlecluster/trainjob_test.go
      • test/integration/singlecluster/controller/jobs/trainjob/trainjob_controller_test.go
      • test/e2e/tas/trainjob_test.go
  • I did not update any localized docs per request (no zh-CN changes).
  • This PR is intended to update the Overview table only and does not make code changes.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NarayanaSabari
Once this PR has been reviewed and has the lgtm label, please assign moficodes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit c1b3612
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6928395fc975680008f3b449
😎 Deploy Preview https://deploy-preview-7950--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @NarayanaSabari. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2025
|-----------------------------------------------------------------------------------------------------------------|----------------|--------|-----------|------------|-------|----------|------------|--------|:------:|-----|------------|--------|------------|------------|-------------|-----------------|
| [Dynamic Reclaim](/docs/concepts/workload/#dynamic-reclaim) | + | + | | | | + | | | | + | | | | | | |
| [MultiKueue](/docs/concepts/multikueue/) | + | + | + | + | + | + | + | + | + | | + | + | + | | | |
| [MultiKueueBatchJobWithManagedBy](/docs/concepts/multikueue/#multikueuebatchjobwithmanagedby-enabled) | + | | | | | + | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature gate is not relevant for the TrainJob. Actually we can remove the row, it is only relavant for batch/Job

Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits

@tenzen-y
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Job-Integrated-Features with TrainJob functionality

4 participants