-
Notifications
You must be signed in to change notification settings - Fork 479
docs: add TrainJob to Job-integrated features table on Overview #7950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add TrainJob to Job-integrated features table on Overview #7950
Conversation
Signed-off-by: narayanasabari <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NarayanaSabari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @NarayanaSabari. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| |-----------------------------------------------------------------------------------------------------------------|----------------|--------|-----------|------------|-------|----------|------------|--------|:------:|-----|------------|--------|------------|------------|-------------|-----------------| | ||
| | [Dynamic Reclaim](/docs/concepts/workload/#dynamic-reclaim) | + | + | | | | + | | | | + | | | | | | | | ||
| | [MultiKueue](/docs/concepts/multikueue/) | + | + | + | + | + | + | + | + | + | | + | + | + | | | | | ||
| | [MultiKueueBatchJobWithManagedBy](/docs/concepts/multikueue/#multikueuebatchjobwithmanagedby-enabled) | + | | | | | + | | | | | | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature gate is not relevant for the TrainJob. Actually we can remove the row, it is only relavant for batch/Job
mimowo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two nits
|
/release-note-none |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add the
TrainJobcolumn to the “Job-integrated features” table on the Overview page and mark the features implemented by TrainJob with+. This update keeps documentation synchronized with the current TrainJob integration implemented in the codebase.Which issue(s) this PR fixes:
Fixes #7864
Special notes for your reviewer:
site/content/en/docs/overview/_index.md.pkg/controller/jobs/trainjob/trainjob_controller.go#L245-286pkg/controller/jobs/trainjob/trainjob_controller.go#L335-350pkg/controller/jobs/trainjob/trainjob_controller.go#L352-376pkg/controller/jobs/trainjob/trainjob_multikueue_adapter.go#L44-88,#L104-115pkg/controller/jobs/trainjob/trainjob_webhook.go#L69-90,#L145-160trainer.kubeflow.org/trainjob:config/components/manager/controller_manager_config.yaml#L56-60test/e2e/singlecluster/trainjob_test.gotest/integration/singlecluster/controller/jobs/trainjob/trainjob_controller_test.gotest/e2e/tas/trainjob_test.gozh-CNchanges).