Skip to content

Change error code for create snapshot in pvCSI to a non-final error #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xing-yang wants to merge 1 commit into
base: master
Choose a base branch
from
+498 −1
Open

Change error code for create snapshot in pvCSI to a non-final error #3797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/csi/service/wcpguest/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,7 +1647,11 @@ func (c *controller) CreateSnapshot(ctx context.Context, req *csi.CreateSnapshot
msg := fmt.Sprintf("volumesnapshot: %s on namespace: %s in supervisor cluster was not Ready. "+
"Error: %+v", supervisorVolumeSnapshotName, c.supervisorNamespace, err)
log.Error(msg)
return nil, status.Error(codes.Internal, msg)
// Note: Set the return code to codes.DeadlineExceeded if VolumeSnapshot is still not ready
// to indicate that the snapshot creation has timed out
// so that external-snapshotter will keep retrying and won't leave
// orphan snapshots behind.
return nil, status.Error(codes.DeadlineExceeded, msg)
}
// Extract the fcd-id + snapshot-id annotation from the supervisor volumesnapshot CR
snapshotID := vs.Annotations[common.VolumeSnapshotInfoKey]
Expand Down
Loading