Skip to content

WIP: fix macos functional tests #22034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ComradeProgrammer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: fix macos functional tests #22034

ComradeProgrammer wants to merge 3 commits into from
+15 −15

Conversation

@ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Dec 4, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2025
@ComradeProgrammer ComradeProgrammer removed the request for review from prezha December 4, 2025 20:55
@ComradeProgrammer ComradeProgrammer changed the title WIP: add macos intergration test WIP: fix macos functional tests Dec 4, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 4, 2025

@ComradeProgrammer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-docker-docker-linux-arm64 7da034a link true /test integration-docker-docker-linux-arm64
integration-docker-docker-linux-x86-64 7da034a link true /test integration-docker-docker-linux-x86-64
integration-docker-containerd-linux-x86-64 7da034a link true /test integration-docker-containerd-linux-x86-64
integration-docker-crio-linux-x86-64 7da034a link true /test integration-docker-crio-linux-x86-64
integration-none-docker-linux-x86-64 7da034a link true /test integration-none-docker-linux-x86-64
integration-kvm-crio-linux-x86-64 7da034a link true /test integration-kvm-crio-linux-x86-64
integration-kvm-docker-linux-x86-64 7da034a link true /test integration-kvm-docker-linux-x86-64
integration-kvm-containerd-linux-x86-64 7da034a link true /test integration-kvm-containerd-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

nirs
nirs reviewed Dec 8, 2025
View reviewed changes
.github/workflows/functional_test.yml
driver: qemu
cruntime: docker
os: macos-13
os: macos-15
Copy link
Contributor

@nirs nirs Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already handled in #22027
But the author is not responsive. Maybe you can take the correct changes to this commit.

Makefile
@(cd hack && go run update/update_all/update_all.go)



Copy link
Contributor

@nirs nirs Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line triggers all actions?

.github/workflows/functional_test.yml
shell: bash
run: |
set -x
set +e
Copy link
Contributor

@nirs nirs Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we set the shell to "bash" and not "bash -e", this should not be needed, since -e is not the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh Awaiting requested review from medyagh

1 more reviewer

@nirs nirs nirs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ComradeProgrammer @k8s-ci-robot @nirs