-
Notifications
You must be signed in to change notification settings - Fork 48
Add Cairo release check workflow #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 79.58% 79.58%
=======================================
Files 108 108
Lines 26739 26739
=======================================
Hits 21280 21280
Misses 5459 5459 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.944 ± 0.066 | 10.859 | 11.072 | 5.23 ± 0.17 |
cairo-native (embedded AOT) |
2.091 ± 0.065 | 2.032 | 2.247 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.157 ± 0.074 | 2.049 | 2.270 | 1.03 ± 0.05 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
565.0 ± 3.7 | 560.1 | 571.0 | 1.00 |
cairo-native (embedded AOT) |
1708.7 ± 25.4 | 1684.7 | 1763.5 | 3.02 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1811.3 ± 31.6 | 1758.4 | 1864.4 | 3.21 ± 0.06 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.844 ± 0.037 | 4.766 | 4.882 | 2.23 ± 0.04 |
cairo-native (embedded AOT) |
2.168 ± 0.038 | 2.104 | 2.233 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.199 ± 0.027 | 2.166 | 2.244 | 1.01 ± 0.02 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.768 ± 0.045 | 4.716 | 4.867 | 2.73 ± 0.07 |
cairo-native (embedded AOT) |
1.749 ± 0.041 | 1.708 | 1.845 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.826 ± 0.035 | 1.775 | 1.879 | 1.04 ± 0.03 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
633.6 ± 4.1 | 626.5 | 640.6 | 1.00 |
cairo-native (embedded AOT) |
1770.9 ± 55.6 | 1712.1 | 1907.1 | 2.79 ± 0.09 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1925.8 ± 32.2 | 1886.0 | 1985.9 | 3.04 ± 0.05 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
534.9 ± 11.3 | 523.2 | 558.0 | 1.00 |
cairo-native (embedded AOT) |
1892.5 ± 15.3 | 1863.4 | 1917.5 | 3.54 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2074.2 ± 21.3 | 2047.8 | 2111.3 | 3.88 ± 0.09 |
…airo_native into add-release-check-workflow
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test this workflow manually, to ensure everything works as expected?
…airo_native into add-release-check-workflow
|
Made a test with this commit. The last cairo's release (2.15.0) seems to have no issues with clippy, meaning it will not trigger the issue creation. |
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fb35055
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9b48acb
fb35055 to
9b48acb
Compare
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add Cairo release check workflow
Closes #1500
Introduces Breaking Changes?
No.
starknet-blocks.ymlworkflow to use these PRs.These PRs should be merged after this one right away, in that order.
Checklist