chore(langchain): fix some no-return-any mypy violations #34249
+238
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
langchain
cbornet
commented
Dec 8, 2025
| result = func(state, runtime) | ||
| if isawaitable(result): | ||
| return await result | ||
| return result |
Collaborator
Author
There was a problem hiding this comment.
we can't get there but mypy doesn't detect it
Collaborator
There was a problem hiding this comment.
For a case like this I'd rather type ignore (and same for the below), could we maybe just add a note?
github-actions
bot
added
infra
cbornet
force-pushed
the
langchain-no-return-any
branch
from
9779c25 to
070388c
Compare
sydney-runkle
requested changes
Dec 12, 2025
Collaborator
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
LGTM other than this, thanks!
| result = func(state, runtime) | ||
| if isawaitable(result): | ||
| return await result | ||
| return result |
Collaborator
There was a problem hiding this comment.
For a case like this I'd rather type ignore (and same for the below), could we maybe just add a note?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we also have #32813 , then we can activate
no-return-anydetection in mypy.