Skip to content

fix(huggingface): Helper logic for init_chat_model with HuggingFace backend #34259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ccurme merged 6 commits into from
Dec 12, 2025
Merged

fix(huggingface): Helper logic for init_chat_model with HuggingFace backend #34259

ccurme merged 6 commits into from
Dec 12, 2025
+53 −5

Conversation

@MirrorDNA-Reflection-Protocol
Copy link
Contributor

@MirrorDNA-Reflection-Protocol MirrorDNA-Reflection-Protocol commented Dec 9, 2025

Fixes #28226.

Issue: 'init_chat_model' was hardcoded to use 'HuggingFacePipeline', causing failures when users expected endpoint usage or when dependencies were mismatched.

Fix:

  1. Added 'ChatHuggingFace.from_model_id' factory method to 'langchain_huggingface' to support 'pipeline', 'endpoint', and 'text-gen' backends via a unified interface.
  2. Updated 'init_chat_model' helper to use this factory, passing kwargs correctly.

Verified:
Verified logic with local isolated reproduction script (due to env constraints).

@github-actions github-actions bot added integration PR made that is related to a provider partner package integration langchain-classic huggingface `langchain-huggingface` package issues & PRs fix For PRs that implement a fix labels Dec 9, 2025
@MirrorDNA-Reflection-Protocol MirrorDNA-Reflection-Protocol changed the title fix(chat_models): Helper logic for init_chat_model with HuggingFace fix(huggingface): Helper logic for init_chat_model with HuggingFace backend Dec 9, 2025
@github-actions github-actions bot added fix For PRs that implement a fix and removed fix For PRs that implement a fix labels Dec 9, 2025
@github-actions github-actions bot added the langchain `langchain` package issues & PRs label Dec 12, 2025
@ccurme ccurme merged commit bf6a5eb into langchain-ai:master Dec 12, 2025
59 checks passed
This was referenced Dec 12, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccurme ccurme ccurme approved these changes

@mdrxy mdrxy Awaiting requested review from mdrxy mdrxy is a code owner

Assignees

No one assigned

Labels

fix For PRs that implement a fix huggingface `langchain-huggingface` package issues & PRs integration PR made that is related to a provider partner package integration langchain `langchain` package issues & PRs langchain-classic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

init_chat_model doesn't work with huggingface models

2 participants

@MirrorDNA-Reflection-Protocol @ccurme