[12.x] Make the Client Response class tappable

[kevinb1989]

When sending API requests to external services, we always have to assign the response to a temporary variable before working on that. making the Illuminate\Http\Client\Response class tappable will remove that hassle.

For example, I have a side project about movies. It is a good idea to only save IMDB id in the DB first, and then use it to retrieve the remaining data of a movie later.

Using tap in combination with macro, the code will be a lot cleaner.

use Illuminate\Http\Client\Response;

Response::macro(
    'movieFields',
    fn () => $this->collect()->only('title', 'year', 'runtime', 'director', 'plot')
);

class MoviesController extends Controller
{
    public function show(Movie $movie)
    {
        if ($movie->missingInformation()) {
            Http::post("http://www.omdbapi.com/?apikey=test_api_key&i={$movie->imdb_id}")
                ->throw()
                ->tap(fn (Response $response) => $movie->update($response->movieFields()));
        }

        return view('movies.show', compact('movie'));
    }
}

I also add a test case for adding macros to that Client Response class.