Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 28, 2026

Note

Medium Risk
Introduces a new FDv2 initializer/synchronizer that reads and auto-reloads flag/segment data from local files, adding threading and file-watching behavior that could affect runtime stability if used incorrectly.

Overview
Adds a new FDv2-compatible file data source (FileDataSourceV2) that can act as both a data system Initializer (fetch) and Synchronizer (sync), loading flags/segments from JSON/YAML files and emitting ChangeSet updates when files change.

Exposes this via a new public LaunchDarkly::Integrations::FileData.data_source_v2 builder (with paths and poll_interval), implements optional file watching via the listen gem with a polling fallback, and includes a comprehensive new spec suite covering load/validation, change detection, and shutdown behavior. Also updates .gitignore to ignore /vendor/bundle.

Written by Cursor Bugbot for commit 23a90bf. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey marked this pull request as ready for review January 28, 2026 20:29
@jsonbailey jsonbailey requested a review from a team as a code owner January 28, 2026 20:29
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@jsonbailey jsonbailey merged commit 852d994 into main Jan 29, 2026
11 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1552/update-file-data-source branch January 29, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants