-
Notifications
You must be signed in to change notification settings - Fork 1.4k
upgrade gatsby-plugin-webpack-bundle-analyser-v2 #6450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e16a95d
5d049b8
989a175
7b22a87
174a6fa
dee4d49
5dff564
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,15 @@ module.exports = { | |
| { | ||
| resolve: "gatsby-plugin-webpack-bundle-analyser-v2", | ||
| options: { | ||
| disable: true, | ||
| }, | ||
| devMode: true, | ||
| disable: process.env.NODE_ENV !== "production", | ||
|
Comment on lines
+37
to
+38
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both will contradicts to each other |
||
| analyzerMode: "server", | ||
| reportFilename: "./report.html", | ||
| openAnalyzer: true, | ||
| analyzerPort: "8888", | ||
| analyzerHost: "http://localhost", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the build is failing because the webpack bundle analyzer is configured with |
||
| defaultSizes: "gzip" | ||
| } | ||
| }, | ||
| { | ||
| resolve: "gatsby-plugin-sitemap", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be not better if it is enabled for development also because we want analyzer to run for dev mode too to check various things like the bundle size and all?