Skip to content

Comments

feat: add several definitions and theorems about reduction systems#211

Merged
chenson2018 merged 8 commits intoleanprover:mainfrom
IvanRenison:ReductionSystem
Jan 28, 2026
Merged

feat: add several definitions and theorems about reduction systems#211
chenson2018 merged 8 commits intoleanprover:mainfrom
IvanRenison:ReductionSystem

Conversation

@IvanRenison
Copy link
Contributor

@IvanRenison IvanRenison commented Dec 11, 2025

This PR adds some additional API to ReductionSystem. While it duplicates from the relation namespace, this seems like an acceptable tradeoff for unifying proofs that use the corresponding notation, and ultimately a user can still simplify to the underlying relation if they desire. (description added by Chris Henson)

@IvanRenison
Copy link
Contributor Author

IvanRenison commented Dec 11, 2025

I don't know why the CI is failing Now the strange error was fixed

@chenson2018
Copy link
Collaborator

I don't know why the CI is failing Now the strange error was fixed

Yes, I retriggered CI manually a couple of times and it then passed, so I assume a transient runner issue.

@chenson2018
Copy link
Collaborator

This PR looks very nice in terms of adding API to ReductionSystem. I worry a bit about having to duplicate everything from Relation, but this all seems correct to me assuming this need. I will review fully probably next week.

@IvanRenison
Copy link
Contributor Author

@chenson2018 don't forget about this pull request. The CI for the last commit was never run

@chenson2018
Copy link
Collaborator

!radar

@leanprover-radar
Copy link

leanprover-radar commented Jan 28, 2026

Benchmark results for 883298e against 7f88669 are in! @chenson2018

Small changes (1🟥)

  • 🟥 build/module/Cslib.Foundations.Semantics.ReductionSystem.Basic//instructions: +3.0G (+36.5%)

@chenson2018
Copy link
Collaborator

@chenson2018 don't forget about this pull request. The CI for the last commit was never run

Thank you for your patience. I was very undecided about the idea of duplication from Relation, but with more examples where I think this will be useful have decided that this is a positive change. I have resolved merge conflicts and added a description.

Copy link
Collaborator

@chenson2018 chenson2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, I think this will be useful!

@chenson2018 chenson2018 added this pull request to the merge queue Jan 28, 2026
Merged via the queue into leanprover:main with commit 77272fc Jan 28, 2026
2 checks passed
@IvanRenison
Copy link
Contributor Author

Thank you!

arademaker pushed a commit to arademaker/cslib that referenced this pull request Jan 29, 2026
…eanprover#211)

This PR adds some additional API to `ReductionSystem`. While it
duplicates from the relation namespace, this seems like an acceptable
tradeoff for unifying proofs that use the corresponding notation, and
ultimately a user can still simplify to the underlying relation if they
desire. (description added by Chris Henson)

---------

Co-authored-by: Chris Henson <chrishenson.net@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants