feat(CI): add shellcheck workflow for shell scripts#229
Merged
chenson2018 merged 2 commits intoleanprover:mainfrom Jan 24, 2026
Merged
feat(CI): add shellcheck workflow for shell scripts#229chenson2018 merged 2 commits intoleanprover:mainfrom
chenson2018 merged 2 commits intoleanprover:mainfrom
Conversation
jessealama
requested review from
chenson2018,
fmontesi and
kim-em
as code owners
Collaborator
|
It seems good to me, can we accept it? |
chenson2018
requested changes
Jan 23, 2026
Collaborator
chenson2018
left a comment
chenson2018
left a comment
There was a problem hiding this comment.
Just some small suggestions. Please merge main as well, as this is needed for the merge queue.
jessealama
force-pushed
the
add-shellcheck-ci
branch
from
9288123 to
3faee36
Compare
chenson2018
approved these changes
Jan 24, 2026
Collaborator
chenson2018
left a comment
chenson2018
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI workflow that runs shellcheck on shell scripts in
scripts/.Related to #202.