-
Notifications
You must be signed in to change notification settings - Fork 752
feat: upstream slice API improvements from human-eval-lean #12352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
352363c to
a7b0fc6
Compare
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 9, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 9, 2026
|
Mathlib CI status (docs):
|
Contributor
Author
|
!radar |
|
Benchmark results for 8e874ca against 39c26fc are in! @datokrat
Medium changes (1🟥)
Small changes (6✅, 12🟥)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
mathlib4-nightly-available
A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the slice API with lemmas for
drop/takeoperations onSubarrayand more lemmas aboutStd.Slice.fold,Std.Slice.foldMandStd.Slice.forIn. It also changes thesimpandgrindannotations forSlice-related lemmas. Lemmas converting between slices of different shapes are no longersimp/grind-annotated because they often complicated lemmas and hindered automation.