feat: add accessor methods for common PaymentKind fields #734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #730.
Added
payment_hash()as requested, but also identified thatpreimageandsecretare common fields shared across mostPaymentKindvariants. Added accessor methods for all three to unify the API.Changes
payment_hash(),preimage(), andsecret()toPaymentKind.PaymentDetailsUpdate::fromto use these new methods, removing boilerplate matching logic.payment_kind_accessor_methodsto verify behavior across all variants (Bolt11, Bolt12, Spontaneous, Onchain).PR Tasks
cargo fmtcargo test