Include non-permanently connected peers in list_peers()#95
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Jun 13, 2023
Merged
Include non-permanently connected peers in list_peers()#95tnull merged 2 commits intolightningdevkit:mainfrom
list_peers()#95tnull merged 2 commits intolightningdevkit:mainfrom
Conversation
tnull
force-pushed
the
2023-05-list-all-peers
branch
4 times, most recently
from
1bfbfe2 to
7b6ac82
Compare
Collaborator
Author
|
Rebased after #85 landed. |
tnull
force-pushed
the
2023-05-list-all-peers
branch
from
7b6ac82 to
a4da746
Compare
Collaborator
Author
|
Rebased on main. |
jkczyz
reviewed
Jun 12, 2023
| (Some(con_addr), Some(_stored_addr)) => NetAddress(con_addr), | ||
| (None, Some(stored_addr)) => stored_addr, | ||
| (Some(con_addr), None) => NetAddress(con_addr), | ||
| (None, None) => continue, |
Collaborator
Author
There was a problem hiding this comment.
As we're using lightning-net-tokio and don't support OnionV3 currently, it shouldn't happen. In particular the conn_addr_opt should always be Some. However, I'd rather skip than unwrap here, as it doesn't hurt and is safer if something ever were to change.
src/types.rs
Outdated
| /// The channel's ID (prior to funding transaction generation, this is a random 32 bytes, | ||
| /// thereafter this is the transaction ID of the funding transaction XOR the funding transaction | ||
| /// output). | ||
| /// The channel ID (prior to funding transaction generation, this is a random 32 byte |
| /// that if we broadcast a revoked state, our counterparty can punish us by claiming at least | ||
| /// this value on chain. | ||
| /// The value, in satoshis, of this channel as it appears in the funding output. | ||
| pub channel_value_sats: u64, |
Contributor
There was a problem hiding this comment.
We use the plural sats but the singular msat below, it seems.
Collaborator
Author
There was a problem hiding this comment.
Mh, true. Possibly we should decide one way and clean up all at once. This is however doesn't feel like the right place to do it?
tnull
force-pushed
the
2023-05-list-all-peers
branch
from
a4da746 to
efec308
Compare
jkczyz
reviewed
Jun 13, 2023
tnull
force-pushed
the
2023-05-list-all-peers
branch
from
0dfee49 to
b10591a
Compare
jkczyz
reviewed
Jun 13, 2023
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Please squash fixups.
tnull
force-pushed
the
2023-05-list-all-peers
branch
from
b10591a to
f562395
Compare
Collaborator
Author
Squashed without further changes. |
jkczyz
approved these changes
Jun 13, 2023
joostjager
pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62,
based on #85This is a follow-up to #56, as we now are able to include non-permanently connected peers in
list_peers().We also include a number of minor doc fixes as a second commit.