Conversation
There was a problem hiding this comment.
First commit looks good, have yet to have a closer look at the second one.
Could you provide a PR description and adjust the title to reflect that it doesn't include just a documentation fix? Also, is the second commit related or should it live in an entirely separate PR?
| params: cmcParams | ||
| ) | ||
|
|
||
| let channelManager = channelManagerConstructor.channelManager |
There was a problem hiding this comment.
While we're here, should we mention the optional fields (in particular the scorer params) below. Users recently seemed unaware how to set them.
|
Eh, I'll split this PR up into two parts. When I pushed the second commit I thought the doc PR had already been merged, and didn't bother pushing to a new remote branch. It should be separate. |
arik-so
force-pushed
the
arik/2023/11/doc_fix
branch
from
cef957a to
b0a7101
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM, mod the optional comment above.
2 participants
No description provided.