Skip to content

Restore lazy flag to KVStore::remove #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Oct 30, 2025

Clarify that all removals must be well-ordered, even `lazy` ones

0f9548b
Select commit
Loading
Failed to load commit list.
Merged

Restore lazy flag to KVStore::remove #4189

Clarify that all removals must be well-ordered, even `lazy` ones
0f9548b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2025 in 0s

88.84% (-0.04%) compared to 02a9af9

View this Pull Request on Codecov

88.84% (-0.04%) compared to 02a9af9

Details

Codecov Report

❌ Patch coverage is 56.25000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (02a9af9) to head (0f9548b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning-persister/src/fs_store.rs 52.38% 5 Missing and 5 partials ⚠️
lightning/src/util/persist.rs 68.75% 3 Missing and 2 partials ⚠️
lightning-background-processor/src/lib.rs 0.00% 2 Missing ⚠️
lightning/src/util/test_utils.rs 60.00% 2 Missing ⚠️
lightning-liquidity/src/lsps2/service.rs 0.00% 1 Missing ⚠️
lightning-liquidity/src/lsps5/service.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4189      +/-   ##
==========================================
- Coverage   88.87%   88.84%   -0.04%     
==========================================
  Files         180      180              
  Lines      137863   137870       +7     
  Branches   137863   137870       +7     
==========================================
- Hits       122522   122485      -37     
- Misses      12532    12573      +41     
- Partials     2809     2812       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov