wip: ppu #2
Open
wip: ppu #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linde12
commented
Nov 25, 2020
| // Need to think about how we should design this. | ||
| // Makes sense that ppu should instead own VRAM, but MMU should | ||
| // still be able to write to VRAM, so MMU would need a mut ref to PPU... | ||
| let mut cpu = Cpu::new(&mut mmu); |
Owner
Author
There was a problem hiding this comment.
to refcell or not to refcell, that is the question - alternatively the ppu could own vram and maybe get LY, STAT, etc. passed to it which makes sense i guess... another solution is to not keep a mutable reference to the mmu in the structs, but pass to step & execute_instruction when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.