-
Notifications
You must be signed in to change notification settings - Fork 70
[feat] Add support for premium_40GB NodeBalancer type #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 73.72% 73.62% -0.10%
==========================================
Files 19 19
Lines 2835 2840 +5
==========================================
+ Hits 2090 2091 +1
- Misses 504 508 +4
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| switch linodego.NodeBalancerPlanType(typeStr) { | ||
| case linodego.NBTypeCommon: // need to add this because of the golint check | ||
| return linodego.NBTypeCommon | ||
| case linodego.NBTypePremium: | ||
| return linodego.NBTypePremium | ||
| case linodego.NBTypePremium40GB: | ||
| return linodego.NBTypePremium40GB | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to warn when the annotation is an invalid type instead of just silently defaulting to the default NBType?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we could warn and then just default to basic NB?
LinodeGo PR that supports this feature: linode/linodego#867
General:
Pull Request Guidelines: