Open
Conversation
Also ``` go mod tidy go mod vendor ``` Signed-off-by: David Scott <dave@recoil.org>
.\hvsock.go:75:5: Fatal call has possible formatting directive %s Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Unfortunately this currently fails because url.Parse is more strict than it used to be: ``` 2022/05/22 15:39:42 Failed to parse hvsock://00000000-0000-0000-0000-000000000000:00001010-FACB-11E6-BD58-64006A7986D3: parse "hvsock://00000000-0000-0000-0000-000000000000:00001010-FACB-11E6-BD58-64006A7986D3": invalid port ":00001010-FACB-11E6-BD58-64006A7986D3" after host exit status 1 FAIL github.com/linuxkit/virtsock/cmd/sock_stress 0.236s ``` Signed-off-by: David Scott <dave@recoil.org>
This avoids the problem with `url.Parse` rejecting the non-integer port. Signed-off-by: David Scott <dave@recoil.org>
rn
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a URL
hvsock://00000000-0000-0000-0000-000000000000:00001010-FACB-11E6-BD58-64006A7986D3would be rejected becauseurl.Parsedoesn't like the non-integer port.Add a test case to demonstrate this, then add a fix to use the URL path, so
hvsock://00000000-0000-0000-0000-000000000000/00001010-FACB-11E6-BD58-64006A7986D3This is on top of #66 (add support for go modules)