-
Notifications
You must be signed in to change notification settings - Fork 210
Fix/change local video track constructor #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/change local video track constructor #971
Conversation
|
|
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
lib/src/track/local/video.dart (1)
177-184: Update the constructor comment to reflect visibilityThe comment says “Private constructor,” but the constructor is now public/internal, which can mislead readers.
💡 Suggested edit
- // Private constructor + // Internal constructor (not part of public API)
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/src/track/local/video.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Build for Flutter Web WASM
- GitHub Check: Build for Flutter Windows
- GitHub Check: Build for Flutter macOS
- GitHub Check: Build for Flutter Linux
- GitHub Check: Build for Flutter Web
- GitHub Check: Build for Flutter iOS
- GitHub Check: Build for Flutter Android
- GitHub Check: Dart Analyze Check
- GitHub Check: Dart Test Check
🔇 Additional comments (1)
lib/src/track/local/video.dart (1)
192-198: LGTM: constructor call sites updated consistentlyAll instantiations now use the new constructor while preserving parameter order and behavior.
Also applies to: 221-227, 250-256
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary by CodeRabbit
Thir PR updates the LocalVideoTrack definition to carry an "@internal" annotation and match the LocalAudioTrack version.
✏️ Tip: You can customize this high-level summary in your review settings.