Fix FileEngine getCompiler() error in viewContainsExpiredFrontMatter#19
Open
richbleeker wants to merge 1 commit intolivewire:mainfrom
Open
Fix FileEngine getCompiler() error in viewContainsExpiredFrontMatter#19richbleeker wants to merge 1 commit intolivewire:mainfrom
richbleeker wants to merge 1 commit intolivewire:mainfrom
Conversation
This fix resolves the 'Call to undefined method Illuminate\View\Engines\FileEngine::getCompiler()' error that occurs when Blaze processes views that use FileEngine (plain PHP templates) instead of CompilerEngine (Blade templates). The issue manifests when: - Email notifications are sent (especially in queued jobs) - Plain PHP views are rendered - Any view using FileEngine or PhpEngine is processed The fix checks if the view engine has the getCompiler() method before attempting to call it. For engines without a compiler (FileEngine, PhpEngine), it returns false, indicating no expired frontmatter to check. This approach is correct because: 1. Non-compiler engines don't compile templates, so they can't have expired frontmatter 2. It's safer and more explicit than catching exceptions 3. It properly caches the result to avoid repeated checks Fixes livewire#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
Call to undefined method Illuminate\View\Engines\FileEngine::getCompiler()error that occurs when Blaze processes views using non-compiler engines.Fixes #12
Problem
The
viewContainsExpiredFrontMatter()method assumes all view engines have agetCompiler()method, but Laravel has multiple view engines:getCompiler()(used for.blade.phpfiles)getCompiler()(used for plain.phpfiles)getCompiler()This causes errors when:
Solution
Added a
method_exists()check before callinggetCompiler(). For engines without a compiler, it returnsfalse(no expired frontmatter).This is correct because non-compiler engines don't compile templates, so they can't have expired frontmatter.
Why This Approach?
Unlike PR #15 which always checks the Blade compiler regardless of the view's actual engine, this fix:
Tests
Added comprehensive test coverage in
tests/FileEngineTest.php:All 141 tests pass (138 existing + 3 new).
Tested On