-
-
Notifications
You must be signed in to change notification settings - Fork 40
Increase maximum users limit from 100 to 200 #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jose-gonzalez-motork, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a potential limitation in multisite installations by doubling the maximum number of users that can be handled within the admin interface. This change aims to enhance usability and scalability for networks with a higher user count, ensuring smoother management without introducing any functional regressions or breaking compatibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly increases the MAX_REFERENCE_USERS limit from 100 to 200. However, this change introduces a failing unit test. The test_reference_user in tests/phpunit/TestMslsAdmin.php contains a hardcoded value in its expected exception message, which now needs to be updated to reflect the new limit. My review comment provides details on how to fix this and improve the test to prevent similar issues in the future.
Replace the number with the constant
Description
This PR increases the maximum number of users handled in the admin interface from 100 to 200.
The previous limit could be restrictive for larger multisite installations. Raising this threshold improves usability and scalability without altering existing behavior or introducing breaking changes.
Changes
includes/MslsAdmin.php.Impact
Allows multisite networks with a higher number of users to be managed more comfortably.
No functional changes outside of the increased limit.
Backward compatible.
Testing
Verified that the admin view loads correctly with more than 100 users.
Confirmed no regressions in existing functionality.