Open
Conversation
added 7 commits
February 25, 2020 00:11
lokiore
commented
Apr 22, 2020
hbase-common/pom.xml
Outdated
| <artifactId>junit</artifactId> | ||
| <groupId>junit</groupId> | ||
| </dependency> | ||
| <dependency> |
mihir6692
reviewed
Apr 22, 2020
| <dependency> | ||
| <groupId>org.bouncycastle</groupId> | ||
| <artifactId>bcprov-jdk15on</artifactId> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
can you combine both compile and test scope with single dependency tag?
mihir6692
reviewed
Apr 22, 2020
| <dependency> | ||
| <artifactId>junit</artifactId> | ||
| <groupId>junit</groupId> | ||
| </dependency> |
There was a problem hiding this comment.
Where is this junit dependency gets used?
There was a problem hiding this comment.
nit : Try to see if you can move that code out of src/java and move it in src/test if possible.
mihir6692
reviewed
Apr 22, 2020
| // Using randomUUID ensures that multiple clusters can be launched by | ||
| // a same test, if it stops & starts them | ||
| Path testDir = getDataTestDir("cluster_" + getRandomUUID().toString()); | ||
| Path testDir = getDataTestDir("cluster_" + HBaseCommonTestingUtility.getRandomUUID().toString()); |
There was a problem hiding this comment.
why not use it directly as it was happening earlier?
mihir6692
reviewed
Apr 22, 2020
| clusterTestDir.deleteOnExit(); | ||
| } | ||
| LOG.info("Created new mini-cluster data directory: " + clusterTestDir + ", deleteOnExit=" + b); | ||
| HBaseCommonTestingUtility.LOG.info("Created new mini-cluster data directory: " + clusterTestDir + ", deleteOnExit=" + b); |
There was a problem hiding this comment.
Why do we need to add HBaseCommonTestingUtility here?
mihir6692
reviewed
Apr 22, 2020
| this.conf.set("fs.defaultFS","file:///"); | ||
| this.conf.set(HConstants.HBASE_DIR, "file://" + dataTestDir); | ||
| LOG.debug("Setting {} to {}", HConstants.HBASE_DIR, dataTestDir); | ||
| HBaseCommonTestingUtility.LOG.debug("Setting {} to {}", HConstants.HBASE_DIR, dataTestDir); |
There was a problem hiding this comment.
Better to create new Logging object instead of using from parent class.
mihir6692
reviewed
Apr 22, 2020
hbase-it/pom.xml
Outdated
| <groupId>org.apache.hbase</groupId> | ||
| <artifactId>hbase-server</artifactId> | ||
| <type>test-jar</type> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Why are we adding test scope here now?
added 2 commits
April 23, 2020 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.