Skip to content

Conversation

@marionbarker
Copy link
Contributor

Purpose

Enable continued use for people running iAPS.

Method

The loopandlearn team noticed this PR: loopnlearn/loopbuildscripts#59

  • that PR modifies the Build_iAPS.sh script to handle the fact that iAPS now uses submodules instead of copies of shared repositories
  • that PR was made against an old repository

New changes are always made to the loopandlearn / lnl-scripts repository and then pushed to the old repository.

This replacement PR is almost identical with the following exception:

  • When testing this, the initial Xcode Scheme was CGMBLEKit Example instead of FreeAPSWorkspace
  • An extra warning statement was added reminding users to select FreeAPSWorkspace before building

Copy link

@friedow friedow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for redirecting this PR to the correct repository.

For future contributers it might be good to add a hint to which repository PRs should be pointed. I think a good place for that hint would be the Developer Tips section in the readme of the loobuildscript repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants