Speed RagTag up a few orders of magnitude on fragmented assemblies with caching#178
Open
twrightsman wants to merge 1 commit intomalonge:masterfrom
Open
Speed RagTag up a few orders of magnitude on fragmented assemblies with caching#178twrightsman wants to merge 1 commit intomalonge:masterfrom
twrightsman wants to merge 1 commit intomalonge:masterfrom
Conversation
Collaborator
|
This is amazing! @mike would you be able to review and integrate?
Thanks so much for your contribution!
Mike
…On Wed, Feb 14, 2024 at 9:51 AM Travis Wrightsman ***@***.***> wrote:
I noticed computing the line numbers of AGP files and objects was ~99% (!)
of the runtime on our very fragmented contig assemblies.
This patch pre-computes the line numbers and dropped runtime from *16
hours to 8 minutes*, the vast majority of which was spent computing the
AGP file to write out.
I have checked this produces identical output on our data, but probably
needs more extensive testing.
------------------------------
You can view, comment on, or merge this pull request online at:
#178
Commit Summary
- 4b43afa
<4b43afa>
Cache AGP file and object line counts
File Changes
(1 file <https://github.com/malonge/RagTag/pull/178/files>)
- *M* ragtag_utilities/AGPFile.py
<https://github.com/malonge/RagTag/pull/178/files#diff-52e0b172693fb269551599232c875d33a2a928e468d3846a65083dd0d552febb>
(16)
Patch Links:
- https://github.com/malonge/RagTag/pull/178.patch
- https://github.com/malonge/RagTag/pull/178.diff
—
Reply to this email directly, view it on GitHub
<#178>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABP347QJFQLRNG2S2SZWNLYTTFOTAVCNFSM6AAAAABDINRPG2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTINJSGY3DONI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed computing the line numbers of AGP files and objects was ~99% (!) of the runtime on our very fragmented contig assemblies.
This patch pre-computes the line numbers and dropped runtime from 16 hours to 8 minutes, the vast majority of which was spent computing the AGP file to write out.
I have checked this produces identical output on our data, but probably needs more extensive testing.