Conversation
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
Tons of changes with no description of why/how these changes improve the codebase and no new tests have been added.
There was a problem hiding this comment.
@jimmywarting could you rebase this branch against master? We're trying to breathe some new life into this repo, so sorry for the delay
I think these changes are great by modernizing the code. The changes aren't actually that big as it's mostly moved code. And I don't think new tests are necessary as it's just a refactor. However, this branch should probably be rebased against master to run against the updated test suite.
I can also vouch for @jimmywarting as one of the major authors of the widely used node-fetch library - including by this library. (Though I think it's be nice if we could swap it out for node's new built-in fetch rather than including an extra dependency. @jimmywarting if you've got any extra time, I'd love some help with that (#743))
|
Please rebase. |
3 participants
No description provided.