[WIP] Adding left side navigation to Layouts above 1024dp#18
[WIP] Adding left side navigation to Layouts above 1024dp#18kford55 wants to merge 3 commits intomaterial-components:developfrom
Conversation
kford55
changed the title
ricknout
left a comment
ricknout
left a comment
There was a problem hiding this comment.
Looking good 👍 Although it's WIP, just one initial comment 😄
I'm getting a NPE when running on a tablet emulator and rotating twice. Seems to be the double bang on binding.bottomAppBarChevron.
Caused by: kotlin.KotlinNullPointerException
at com.materialstudies.reply.ui.MainActivity.setUpBottomNavigationAndFab(MainActivity.kt:84)
at com.materialstudies.reply.ui.MainActivity.onCreate(MainActivity.kt:58)
| binding.fab?.let { fab -> | ||
| fab.apply { |
There was a problem hiding this comment.
Nitpick: I think this could be combined into a single binding.fab?.apply { (same applies to other changes below)
There was a problem hiding this comment.
Yeaa me and @hunterstich were talking about this yesterday. This as of now is a get stuff moving and started (probably gonna push the nav stuff until some of the other parts are built) but there is some changes we have to make to make this cleaner and hopefully less gross around the optionals and all that as there's definitely some lifecycle things that can cause issues here.
2 participants
Initial start to bringing the tablet and desktop layouts to Reply. This WIP PR brings the rail navigation component and an initial layout where it's added to the left side on 1024dp or greater window sizes.