Skip to content

Conversation

@janosh
Copy link
Member

@janosh janosh commented Nov 25, 2025

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.97%. Comparing base (a305609) to head (93d1ca1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/custodian/vasp/handlers.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   53.02%   52.97%   -0.05%     
==========================================
  Files          39       39              
  Lines        3508     3511       +3     
==========================================
  Hits         1860     1860              
- Misses       1648     1651       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janosh
Copy link
Member Author

janosh commented Dec 3, 2025

@shyuep could you take a look? also @esoteric-ephemera curious if you've seen this error before and if so, how you worked around it

@shyuep
Copy link
Member

shyuep commented Dec 3, 2025

I am fine with this. Merged.

@shyuep shyuep merged commit 5767f84 into materialsproject:master Dec 3, 2025
8 checks passed
@janosh janosh deleted the fix-walltime-handler-crash-on-incomplete-outcar branch December 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outcar parsing error from pymatgen

3 participants