Allow zero as value to certain tracking parameters#362
Open
aleximenes wants to merge 2 commits intomatomo-org:mainfrom
Open
Allow zero as value to certain tracking parameters#362aleximenes wants to merge 2 commits intomatomo-org:mainfrom
aleximenes wants to merge 2 commits intomatomo-org:mainfrom
Conversation
Prior to this change, the parameters changed within this commit did not allow zero as a value as the minimum value they were compared to was 4.9E-324. Fixes matomo-org#361
Author
|
Both of the actions fail with the same error: I don't see how this is related to the change that I have made as I have not touched any dependencies. This seems to be related to change with See the below line for where it fails: It seems that this is related to the update that happened by Dependabot in f2e2da3, where it updated the version of jetty.servlet from 10.0.24 to 11.0.0 |
….0.24 to 11.0.0 (matomo-org#312)" This reverts commit f2e2da3. The change upgraded `matomo-java-tracker-servlet-javax` to the next version of `jetty-servlet`, which started to use `jakarta`, making it incompatible with this library.
Author
|
As mentioned in the commit, I reverted the change to This should fix the failing builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the parameters changed within this commit
did not allow zero as a value as the minimum value they were
compared to was 4.9E-324.
Fixes #361