-
Notifications
You must be signed in to change notification settings - Fork 13
Update Gemfile.lock during release #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @horgh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the release process by integrating Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the release script to automatically update Gemfile.lock during a release. The changes are sound, adding a pre-flight check for bundle and then running bundle install to update the lockfile after the version is bumped in the gemspec. My review includes one suggestion to make the dependency update more targeted to avoid including unrelated gem updates in the release commit.
| perl -pi -e "s/(?<=s.version\s{,20}=\s{,20}\').+?(?=\')/$version/g" maxmind-db.gemspec | ||
|
|
||
| # Update version in Gemfile.lock. | ||
| bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using bundle install can update all dependencies in Gemfile.lock if newer versions are available, not just the maxmind-db gem. This could unintentionally bundle unrelated dependency updates into the release commit.
To make the update more targeted, consider using bundle update maxmind-db. This will only update the maxmind-db gem and its dependencies if necessary, keeping the release commit focused on the version change.
| bundle install | |
| bundle update maxmind-db |
This ensures CI fails immediately with a clear error if Gemfile.lock is out of sync, rather than silently updating it. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This fixes JRuby CI builds which were failing with BUNDLE_FROZEN=true because the lockfile lacked JRuby-compatible gem variants. Co-Authored-By: Claude Opus 4.5 <[email protected]>
No description provided.