Skip to content

[#42] Removing purge_networks as it no longer works with Ansible 11+ #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alextreme wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[#42] Removing purge_networks as it no longer works with Ansible 11+ #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2840db1
[#42] Removing purge_networks as it no longer works with Ansible 11+
alextreme Oct 10, 2025
e52af11
[#42] Adding networks: strict as replacement for purge_networks
alextreme Oct 15, 2025
3a6308e
[#42] Ensuring backwards-compatibility with Ansible 10
alextreme Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/django_app_docker/templates/django-container.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ published_ports:
comparisons:
env: strict
volumes: strict
networks: strict
3 changes: 2 additions & 1 deletion roles/django_app_docker/templates/networks.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ binds containers ONLY to the app network. -#}
networks:
- name: "{{ django_app_docker_name_prefix }}"
network_mode: "{{ django_app_docker_name_prefix }}"
purge_networks: true
networks_cli_compatible: true
{% if ansible_version.major == 2 and ansible_version.minor <= 10 %}purge_networks: true{% endif %}
Copy link
Collaborator

@SilviaAmAm SilviaAmAm Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate 🤔 I had locally 2.17.14 for the ansible-core version in commonground-deployment, so then I would be missing this.

Since we don't specify in all repo specific ansible version requirements, maybe we should make all the upgrades for newer ansible versions in one go and then update all the repositories 🤔

Copy link
Member Author

@alextreme alextreme Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the idea, that you would only have purge_networks for older ansible-core versions?

ansible-core 2.10 is more or less ancient ( https://endoflife.date/ansible-core ) however I noticed that the Sjoerd-repo's still explicitly state installing ansible==10.x


Loading