Skip to content

Conversation

@Floris272
Copy link
Contributor

@Floris272 Floris272 commented Dec 4, 2025

Partially fixes #564

Changes

  • adds ObjectType fields to existing ObjectType model
  • adds ObjectTypeVersionModel
  • adds command to import types and versions from an objecttypes api service

To make the migration easier i would suggest to first only merge this pr that adds the model and the command and add everything from objecttypes in the next pr/release.

The update path would be to update objects to 3.6.0 which will include the script which just needs to be run before updating to 3.7.0 which would include the whole refactor.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 92.72727% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.61%. Comparing base (6272c8c) to head (b509007).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/objects/core/models.py 89.79% 4 Missing and 1 partial ⚠️
src/objects/core/utils.py 50.00% 5 Missing ⚠️
...cts/core/management/commands/import_objecttypes.py 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   84.12%   84.61%   +0.49%     
==========================================
  Files         134      138       +4     
  Lines        2576     2737     +161     
  Branches      208      215       +7     
==========================================
+ Hits         2167     2316     +149     
- Misses        362      373      +11     
- Partials       47       48       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🐰 Bencher Report

Branchfeature/564-import-objecttypes-command
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
114.04 ms
(+1.32%)Baseline: 112.56 ms
118.19 ms
(96.50%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
20.45 ms
(+1.53%)Baseline: 20.14 ms
21.14 ms
(96.69%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
274.73 ms
(+1.26%)Baseline: 271.30 ms
284.87 ms
(96.44%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
276.90 ms
(+1.22%)Baseline: 273.57 ms
287.25 ms
(96.40%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
129.57 ms
(+1.97%)Baseline: 127.06 ms
133.41 ms
(97.12%)
🐰 View full continuous benchmarking report in Bencher

@Floris272 Floris272 marked this pull request as ready for review December 5, 2025 15:59
@Floris272 Floris272 requested a review from stevenbal December 5, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenObjecten - combine the ObjectsType API into the Objects API

3 participants