Skip to content

[WC-2942]: Fix carousel focus indicator #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HedwigAR wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[WC-2942]: Fix carousel focus indicator #1969

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b12864
fix: add focus indicators to previous and next button
HedwigJDoets Nov 4, 2025
fa8168b
fix: disable autoplay by default since it's not accessible
HedwigJDoets Nov 4, 2025
a0bb027
feat: add background to carousel nav buttons
HedwigJDoets Nov 7, 2025
87ac807
chore: update changelog
HedwigJDoets Nov 7, 2025
95db479
fix: use css variables
HedwigJDoets Dec 9, 2025
d78739b
fix: use variable for background color of swiper button
HedwigJDoets Dec 10, 2025
0a6d190
fix: add fallback css variables
HedwigJDoets Dec 10, 2025
71a6da3
fix: add comment with explanation of css variables
HedwigJDoets Dec 10, 2025
31c8516
fix: add fallback for variables
HedwigJDoets Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/carousel-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- Added focus indicator and background to navigation buttons of carousel, removed autoplay by default

## [2.3.0] - 2025-08-19

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/carousel-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@mendix/carousel-web",
"widgetName": "Carousel",
"version": "2.3.0",
"version": "2.3.1",
"description": "Displays images in a carousel",
"copyright": "© Mendix Technology BV 2025. All rights reserved.",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/carousel-web/src/Carousel.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<caption>Navigation controls</caption>
<description />
</property>
<property key="autoplay" type="boolean" defaultValue="true">
<property key="autoplay" type="boolean" defaultValue="false">
<caption>Auto play</caption>
<description />
</property>
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/carousel-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Carousel" version="2.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Carousel" version="2.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Carousel.xml" />
</widgetFiles>
Expand Down
14 changes: 14 additions & 0 deletions packages/pluggableWidgets/carousel-web/src/ui/Carousel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@
align-items: center;
}

.swiper-button-next,
.swiper-button-prev {
--swiper-navigation-size: 24px;
border-radius: 50%;
background-color: rgba(245, 245, 245, 0.7);
Copy link
Collaborator

@gjulivan gjulivan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--gray-700 ?

Copy link
Contributor Author

@HedwigAR HedwigAR Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but why that specifically?

Copy link
Collaborator

@gjulivan gjulivan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not specific to that. Maybe other color that is similar and currently available.

Copy link
Contributor Author

@HedwigAR HedwigAR Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used --gray-200 since that gave the right amount of color contrast

padding: 2em;
Copy link
Collaborator

@gjulivan gjulivan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use spacing small, large, or medium?

}

.swiper-button-next:focus,
.swiper-button-prev:focus {
outline: 2px solid #264ae5;
Copy link
Collaborator

@gjulivan gjulivan Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a css variables for this?
i think it should be var(--focus-outline)

outline-offset: 2px;
Copy link
Collaborator

@gjulivan gjulivan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var(--focus-outline-offset)

}

.swiper-slide img {
display: block;
width: 100%;
Expand Down
Loading