MES-715: Check for updates in the background for faster bootup#34
Conversation
Mesa DescriptionThis PR moves the software update check to a background task, allowing the application to start up faster. Previously, the update check was a blocking operation in the main startup path. This could cause noticeable delays, especially on slow network connections. By making the check asynchronous and running it in a background task after the daemon has started, the application becomes responsive to the user much more quickly. Changes
Description generated by Mesa. Update settings |
41c2d5f to
a9f64c7
Compare
There was a problem hiding this comment.
Performed full review of b6f03ac...41c2d5f
Analysis
- Update notifications are now limited to daemon startup only, potentially reducing visibility for operators who primarily use CLI management commands.
- The background update checking lacks observability hooks and proper testing infrastructure.
- The async implementation could benefit from dependency injection to improve testability of the background job.
- Consider implementing a lightweight signaling mechanism or cache system to restore update notification visibility across CLI commands.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 1 comments | Edit Agent Settings • Read Docs
|
|
||
| updates::check_for_updates(); | ||
|
|
||
| let args = Args::parse(); |
There was a problem hiding this comment.
Removing the synchronous updates::check_for_updates() call means only the daemon startup path will ever trigger an update warning. Commands such as git-fs reload (which talk to an already-running daemon but do not start it) used to surface the warning on every invocation, but now they will never emit it. If that isn’t intentional, we may need to keep a non-blocking check (or a stub that notifies the daemon) for those management commands as well.
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: mesa-dot-dev/gitfs#34
File: src/main.rs#L61
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Removing the synchronous `updates::check_for_updates()` call means only the daemon startup path will ever trigger an update warning. Commands such as `git-fs reload` (which talk to an already-running daemon but do not start it) used to surface the warning on every invocation, but now they will never emit it. If that isn’t intentional, we may need to keep a non-blocking check (or a stub that notifies the daemon) for those management commands as well.
No description provided.