Replaces narrow strings with wide ones in long vector test execution tests. #7882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
danbrown-amd
force-pushed
the
long-vector-test-wide-strings
branch
from
6d927e5 to
a52822b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alsepkow
approved these changes
Nov 6, 2025
Contributor
alsepkow
left a comment
alsepkow
left a comment
There was a problem hiding this comment.
LGTM. I'm surprised this wasn't already failing!
V-FEXrt
approved these changes
Nov 7, 2025
damyanp
requested changes
Nov 7, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
I'd like to dig a bit deeper before making this change. Is this really the right fix?
Member
|
Closing - this was addressed via #7888 as this solution was working around an issue with using a very old version of TAEF that we should not have been recommending people use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7881.