[NFC] Fix build issues with newer libcxx #7926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't really useful since we have constant expressions for the size in each case already, but depending on _countof makes this fragile to implementation details of the C++ standard library. Chromium encountered a build failure due to this dependency with the latest libc++.
llvm-beanz
changed the title
s-perron
approved these changes
Nov 18, 2025
damyanp
approved these changes
Nov 18, 2025
Collaborator
|
Is the build failure a flake? Is there a way to kick off another build? |
Member
It looks like the gcc / debug builds are pretty consistently running out of disk space. We're looking in ways to mitigate this. For this change I'll force the merge accepting the unrelated build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a few uses of
_countofwhere we already have constant expressions for sizes with the constant expressions, usesstd::sizein other places, and adds a missing include to<cstdlib>.Chromium encountered a build failure due to these issues with the latest libc++.