File tree Expand file tree Collapse file tree 1 file changed +6
-0
lines changed
packages/dds/shared-object-base/src Expand file tree Collapse file tree 1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -142,6 +142,12 @@ class SharedObjectFromKernel<
142142 logger : this . logger ,
143143 idCompressor : runtime . idCompressor ,
144144 lastSequenceNumber : ( ) => this . deltaManager . lastSequenceNumber ,
145+
146+ // This cast is needed since IFluidDataStoreRuntimeInternalConfig does not extend IFluidDataStoreRuntime directly. This pattern
147+ // allows us to avoid breaking changes to IFluidDataStoreRuntime by hiding internal members in a separate interface, but comes
148+ // at the cost of less compile-time enforcement. For example, if the runtime did not implement `minVersionForCollab` and the
149+ // member was still optional (e.g., during the deprecation window where backwards-compatibility is maintained), the compiler
150+ // would emit an error.
145151 minVersionForCollab : ( runtime as IFluidDataStoreRuntimeInternalConfig )
146152 . minVersionForCollab ,
147153 } ;
You can’t perform that action at this time.
0 commit comments