Skip to content

Commit 45f8a0d

Browse files
authored
fix(build-tools): Fix typetests header version format (#25830)
## Description This PR removes the pre-release/metadata from the current version when generating the header for typetest files. For example, if the current version is `1.2.3-foo` the file would be generated with `1.2.3` instead. This is important since it prevents CI builds from changing the typetests files unexpectedly.
1 parent 7cbd4a8 commit 45f8a0d

File tree

1 file changed

+5
-1
lines changed
  • build-tools/packages/build-cli/src/commands/generate

1 file changed

+5
-1
lines changed

build-tools/packages/build-cli/src/commands/generate/typetests.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { Flags } from "@oclif/core";
1616
import { PackageName } from "@rushstack/node-core-library";
1717
import * as changeCase from "change-case";
1818
import { readJson } from "fs-extra/esm";
19+
import { major, minor, patch } from "semver";
1920
import {
2021
type JSDoc,
2122
ModuleKind,
@@ -164,6 +165,9 @@ export default class GenerateTypetestsCommand extends PackageCommand<
164165
? [buildToolsImport, previousImport]
165166
: [previousImport, buildToolsImport];
166167

168+
// Remove pre-release/metadata from the current version (e.g., "1.2.3-foo" -> "1.2.3")
169+
const currentVersionBase = `${major(currentPackageJson.version)}.${minor(currentPackageJson.version)}.${patch(currentPackageJson.version)}`;
170+
167171
const fileHeader: string[] = [
168172
`/*!
169173
* Copyright (c) Microsoft Corporation and contributors. All rights reserved.
@@ -175,7 +179,7 @@ export default class GenerateTypetestsCommand extends PackageCommand<
175179
* Generated by flub generate:typetests in @fluid-tools/build-cli.
176180
*
177181
* Baseline (previous) version: ${previousPackageJson.version}
178-
* Current version: ${currentPackageJson.version}
182+
* Current version: ${currentVersionBase}
179183
*/
180184
181185
${imports.join("\n")}

0 commit comments

Comments
 (0)