-
Notifications
You must be signed in to change notification settings - Fork 559
Upgrade biome from version 1.9 to 2.3.8 and simplify configs (config-only, no formatting) #25965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
20
commits into
main
Choose a base branch
from
copilot/upgrade-biome-version-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+463
−1,120
Draft
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c3ed98b
Initial plan
Copilot c32fd0b
Upgrade biome to 2.3.8 and update configs
Copilot 6673421
Fix biome config overrides and formatting
Copilot e7a7656
Update lockfile and fix policy check
Copilot df5c73c
Fix sample-executable.esm.ts file
Copilot 4a9a526
Change line width to 120 to minimize formatting churn
Copilot 571d0a1
Upgrade biome from version 1.9 to 2.3.8 and simplify configs
Copilot 6808350
Revert formatting changes, keep only config and upgrade changes
Copilot 850b42d
Remove duplicate biome configs and fix test data issues
Copilot e2f1250
Restore all comments and spacing in biome config files
Copilot dbd8473
Remove accidentally committed original_biome.jsonc
Copilot 078a19a
Merge branch 'main' into copilot/upgrade-biome-version-2
tylerbutler 3952102
Merge branch 'main' into copilot/upgrade-biome-version-2
tylerbutler 92e7f41
use overrides
tylerbutler 743c48e
update biome configs
tylerbutler 8be9683
ignore biome 1 test data
tylerbutler d9a14fe
Merge branch 'main' into copilot/upgrade-biome-version-2
tylerbutler 8041697
restore biome v1 data file
tylerbutler 5aa9760
Update biome.jsonc
tylerbutler 17ed353
Apply suggestions from code review
tylerbutler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| { | ||
| "$schema": "./node_modules/@biomejs/biome/configuration_schema.json", | ||
| "extends": ["../../../biome.jsonc"] | ||
| "root": false, | ||
| "overrides": [ | ||
| { | ||
| "includes": ["**/.vscode/**/*.json", "**/tsconfig*.json"], | ||
| "json": { | ||
| "parser": { | ||
| "allowComments": true, | ||
| "allowTrailingCommas": true | ||
| }, | ||
| "formatter": { | ||
| "trailingCommas": "all" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| { | ||
| "$schema": "./node_modules/@biomejs/biome/configuration_schema.json", | ||
| "extends": ["../../../biome.jsonc"] | ||
| "root": false, | ||
| "overrides": [ | ||
| { | ||
| "includes": ["**/.vscode/**/*.json", "**/tsconfig*.json"], | ||
| "json": { | ||
| "parser": { | ||
| "allowComments": true, | ||
| "allowTrailingCommas": true | ||
| }, | ||
| "formatter": { | ||
| "trailingCommas": "all" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,7 +93,7 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@arethetypeswrong/cli": "^0.17.1", | ||
| "@biomejs/biome": "~1.9.3", | ||
| "@biomejs/biome": "~2.3.8", | ||
| "@fluid-tools/build-cli": "^0.60.0", | ||
| "@fluidframework/azure-service-utils-previous": "npm:@fluidframework/[email protected]", | ||
| "@fluidframework/build-common": "^2.0.3", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,39 @@ | ||
| { | ||
| "root": false, | ||
tylerbutler marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "$schema": "./node_modules/@biomejs/biome/configuration_schema.json", | ||
tylerbutler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "extends": ["../biome.jsonc"], | ||
| "organizeImports": { | ||
| "enabled": true | ||
| "assist": { | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| } | ||
| }, | ||
| "formatter": { | ||
| "enabled": true | ||
| }, | ||
| "files": { | ||
| "ignore": ["packages/build-tools/src/test/data/biome/empty.jsonc"] | ||
| } | ||
| "includes": [ | ||
| "**", | ||
| "!**/packages/build-tools/src/test/data/biome/empty.jsonc" | ||
| ] | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "includes": [ | ||
| "**/.vscode/**/*.json", | ||
| "**/tsconfig*.json", | ||
| "**/api-extractor*.json", | ||
| "**/tsdoc*.json" | ||
| ], | ||
| "json": { | ||
| "parser": { | ||
| "allowComments": true, | ||
| "allowTrailingCommas": true | ||
| }, | ||
| "formatter": { | ||
| "trailingCommas": "all" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.