Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Dec 5, 2025

Promotes the eslint config from minimal-deprecated to recommended and fixes resulting linter violations

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the ESLint configuration from the deprecated minimal-deprecated config to the recommended config and fixes all resulting linter violations.

Key changes:

  • Upgraded ESLint config to use stricter, more comprehensive rules
  • Added explicit return type annotations to all functions and methods
  • Converted value imports to type imports using import type syntax for better tree-shaking

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.eslintrc.cjs Updated ESLint config from minimal-deprecated to recommended configuration
src/view.ts Added type import and return type annotations to functions
src/taskManagerDiceRoller.ts Added type imports and return type annotations to all methods and getters
src/oldestClientDiceRoller.ts Added type import and return type annotations to all methods and getters
src/containerCode.ts Added type imports and return type annotations to protected methods
src/app.ts Added type import, return type annotation, changed substring to slice, changed getElementById to querySelector, refactored error handling to use top-level await with try-catch, and added eslint-disable comment for atomic updates

/**
* Start the app and render.
*
* @remarks We wrap this in an async function so we can await Fluid's async calls.
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "we wrap this in an async function" but with the new top-level await pattern (lines 70-74), this explanation is now outdated. Consider updating the comment to reflect that the function is called at the top level with proper error handling.

Suggested change
* @remarks We wrap this in an async function so we can await Fluid's async calls.
* @remarks This function is called at the top level using top-level await, allowing us to await Fluid's async calls and handle errors properly.

Copilot uses AI. Check for mistakes.
@Josmithr Josmithr enabled auto-merge (squash) December 5, 2025 23:53
@Josmithr Josmithr merged commit 1d33e00 into microsoft:main Dec 6, 2025
34 checks passed
@Josmithr Josmithr deleted the task-selection/promote-eslint-config branch December 8, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants