Linux compiler fixes for Clang and GCC when using -Werror #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code threw on error on newer clang and gcc versions where
-Werror was enabled, as the compiler wants a set of brackets present in
the initialization value for each container level in the lvalue's data
type. This change replaces the {0,} initializations with {{0}}, which
satisfies the compiler warnings.
This needs to be an unsigned integer before we can perform the comparison, in order to satisfy a compiler warning about signedness.
Author
|
Might as well drop a mention to microsoft/SysmonForLinux#36 in here, as it contains the related changes to the Linux port of Sysmon. |
Contributor
|
This looks good - many thanks. As SysmonCommon is shared, I need to feed this back via a PR into the internal ADO first; when we have approval for that, I'll approve this one here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes here are
{0,}->{{0}}cleanups similar to what's done in microsoft/SysmonForLinux@ea0aa15.As well, there is one missing cast (converting a signed to unsigned int type). I think that this is fine, but someone else might want to double check the potential values of
prevLastEventOffsetin this context. It was being tested againstULONG_MAXwhich threw a warning when the types didn't match.