Added OOBE key check on first run#1953
Open
avdeshjadon wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
avdeshjadon
had a problem deploying
to
development-fork
GitHub Actions
Failure
avdeshjadon
had a problem deploying
to
development-fork
GitHub Actions
Failure
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Author
|
@microsoft-github-policy-service agree |
robgruen
changed the title
robgruen
reviewed
Mar 2, 2026
| if (result.response === 0) { | ||
| shell.openExternal( | ||
| "https://github.com/microsoft/TypeAgent/blob/main/ts/README.md", | ||
| ); |
Collaborator
There was a problem hiding this comment.
Let's exit the application after the user selects "open external." When I did the main app continued to execute and throw an error which was a bit unexpected and a lesser user experience. If the user hits "continue anyway" I think it's ok to fail like this.
avdeshjadon
requested a deployment
to
development-fork
GitHub Actions
Waiting
avdeshjadon
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a check on first run to see if the required api keys are set. if they're missing, it shows a dialog with what keys are needed and a button to open the setup docs.
Closes #1892