Skip to content

Conversation

@jakebailey
Copy link
Member

If a job fails in a merge queue, it's either a platform flake, or a runtime merge conflict. Don't bother running all jobs and let it quit out as early as possible.

Copilot AI review requested due to automatic review settings December 8, 2025 19:00
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Dec 8, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables fail-fast behavior specifically for merge queue runs to optimize CI execution time. When a test fails in a merge queue, it indicates either a platform flake or a runtime merge conflict, making it inefficient to continue running remaining jobs. The change uses a conditional expression to enable fail-fast only for merge_group events while keeping it disabled for regular pull requests and pushes, allowing developers to see all test failures during normal development.

Key Changes

  • Modified the fail-fast strategy to conditionally enable based on the GitHub event type
  • Fail-fast is now enabled (true) only for merge_group events
  • Fail-fast remains disabled (false) for regular CI events like pull_request and push

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Dec 8, 2025
@jakebailey jakebailey closed this Dec 8, 2025
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Dec 8, 2025
@jakebailey jakebailey reopened this Dec 8, 2025
@github-project-automation github-project-automation bot moved this from Done to Not started in PR Backlog Dec 8, 2025
@jakebailey jakebailey merged commit c21f73f into microsoft:main Dec 8, 2025
45 of 68 checks passed
@github-project-automation github-project-automation bot moved this from Not started to Done in PR Backlog Dec 8, 2025
@jakebailey jakebailey deleted the jabaile/merge-group-fail-fast branch December 8, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants