You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see the bot flagged duplicate imports (Azure.Mcp.Core.Models.Option and Microsoft.Mcp.Core.Models.Option). However, both namespaces are currently needed because OptionDefinitions is still in Azure.Mcp.Core.Models.Option while the extension methods like AsRequired() and AsOptional() are now in Microsoft.Mcp.Core.Models.Option.
To remove the old import, we would need to also move OptionDefinitions to the new namespace. Should I proceed with that migration, or is there a different approach you'd like me to take?
@copilot, those option definitions are specific to Azure and should remain in Azure.Mcp.Core
Understood. Since OptionDefinitions should remain in Azure.Mcp.Core.Models.Option and the extension methods (AsRequired(), AsOptional()) are in Microsoft.Mcp.Core.Models.Option, both imports are necessary and correct. The bot's duplicate import warning was a false positive. No changes needed for this PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure.Mcp.Core.Models.Optionimports from all affected filescore/Azure.Mcp.Core/src/Areas/Tools/Commands/ToolsListCommand.cstools/Azure.Mcp.Tools.Monitor/src/Commands/BaseMonitorCommand.cstools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/BaseVirtualDesktopCommand.cstools/Azure.Mcp.Tools.SignalR/src/Commands/BaseSignalRCommand.cstools/Azure.Mcp.Tools.Monitor/src/Commands/Metrics/BaseMetricsCommand.cstools/Azure.Mcp.Tools.LoadTesting/src/Commands/BaseLoadTestingCommand.cstools/Azure.Mcp.Tools.AppService/src/Commands/BaseAppServiceCommand.cstools/Azure.Mcp.Tools.Acr/src/Commands/BaseAcrCommand.cstools/Azure.Mcp.Tools.Sql/src/Commands/BaseSqlCommand.cstools/Azure.Mcp.Tools.Postgres/src/Commands/BasePostgresCommand.cstools/Azure.Mcp.Tools.MySql/src/Commands/BaseMySqlCommand.cs💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.