-
Notifications
You must be signed in to change notification settings - Fork 316
Add DangerouslyWriteSupportLogsToDir support #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xiangyan99
wants to merge
7
commits into
main
Choose a base branch
from
DangerouslyEnableSupportLogging_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+670
−8
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76a3466
Add DangerouslyEnableSupportLogging support
xiangyan99 23dcb0b
address feedback
xiangyan99 67893f7
Merge branch 'main' into DangerouslyEnableSupportLogging_support
xiangyan99 c9d5c8a
Merge branch 'main' into DangerouslyEnableSupportLogging_support
xiangyan99 7540a34
address feedback
xiangyan99 a7691e9
updates
xiangyan99 39b2199
add file rotation. if the server runs for multiple hours, we'll have …
xiangyan99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace Azure.Mcp.Core.Logging; | ||
|
|
||
| /// <summary> | ||
| /// A simple file logger that writes logs to a file for support and troubleshooting purposes. | ||
| /// </summary> | ||
| internal sealed class FileLogger(string categoryName, FileLoggerProvider provider) : ILogger | ||
| { | ||
| private readonly string _categoryName = categoryName; | ||
| private readonly FileLoggerProvider _provider = provider; | ||
|
|
||
| /// <inheritdoc/> | ||
| public IDisposable? BeginScope<TState>(TState state) where TState : notnull => null; | ||
|
|
||
| /// <inheritdoc/> | ||
| public bool IsEnabled(LogLevel logLevel) => logLevel != LogLevel.None; | ||
|
|
||
| /// <inheritdoc/> | ||
| public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception? exception, Func<TState, Exception?, string> formatter) | ||
| { | ||
| if (!IsEnabled(logLevel)) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| var message = formatter(state, exception); | ||
| var timestamp = DateTime.UtcNow.ToString("yyyy-MM-dd HH:mm:ss.fff"); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we consider using something like SeriLog as suggested in this issue? It provides several configurable options including log rotation. |
||
| var logLevelString = GetLogLevelString(logLevel); | ||
|
|
||
| var logEntry = $"[{timestamp}] [{logLevelString}] [{_categoryName}] {message}"; | ||
|
|
||
| if (exception != null) | ||
| { | ||
| logEntry += Environment.NewLine + exception.ToString(); | ||
| } | ||
|
|
||
| _provider.WriteLog(logEntry); | ||
| } | ||
|
|
||
| private static string GetLogLevelString(LogLevel logLevel) => logLevel switch | ||
| { | ||
| LogLevel.Trace => "TRCE", | ||
| LogLevel.Debug => "DBUG", | ||
| LogLevel.Information => "INFO", | ||
| LogLevel.Warning => "WARN", | ||
| LogLevel.Error => "ERRR", | ||
| LogLevel.Critical => "CRIT", | ||
| _ => "NONE" | ||
| }; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.