Skip to content

chore: release a new major version of tick and seatbelt crate#259

Open
martintmk wants to merge 9 commits intomainfrom
release-tick
Open

chore: release a new major version of tick and seatbelt crate#259
martintmk wants to merge 9 commits intomainfrom
release-tick

Conversation

@martintmk
Copy link
Member

@martintmk martintmk commented Feb 13, 2026

No description provided.

@codecov
Copy link

codecov bot commented Feb 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (7ab2a9d) to head (1c703c2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         140      140           
  Lines        8620     8620           
=======================================
  Hits         8620     8620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martintmk martintmk marked this pull request as ready for review February 13, 2026 15:00
@Vaiz
Copy link
Contributor

Vaiz commented Feb 13, 2026

it's a semver incompatible release
to avoid duplicated deps, could you bump seatbelt as well?

cargo tree -i tick        
tick v0.1.2 (C:\dev\oxidizer\crates\tick)
└── seatbelt v0.2.0 (C:\dev\oxidizer\crates\seatbelt)
[dev-dependencies]
├── anyspawn v0.1.0 (C:\dev\oxidizer\crates\anyspawn)
├── seatbelt v0.2.0 (C:\dev\oxidizer\crates\seatbelt)
└── uniflight v0.1.0 (C:\dev\oxidizer\crates\uniflight)

@martintmk martintmk mentioned this pull request Feb 15, 2026
Merged
@martintmk martintmk marked this pull request as draft February 15, 2026 13:16
martintmk added a commit that referenced this pull request Feb 17, 2026
@martintmk
feat(tick): rename MIN to UNIX_EPOCH (#262)
64d0a2e 
To better align the naming with `SystemTime::UNIX_EPOCH`. This is
breaking change, but we are releasing a new major version in #259
anyway.
@martintmk martintmk marked this pull request as ready for review February 17, 2026 09:08
@martintmk martintmk enabled auto-merge (squash) February 17, 2026 09:08
@martintmk
Copy link
Member Author

martintmk commented Feb 17, 2026 •
edited
Loading

t's a semver incompatible release

Once released, I'll bump all these.

@sandersaares
Copy link
Member

sandersaares commented Feb 17, 2026

Once released, I'll bump all these.

Why not all together?

@sandersaares sandersaares self-requested a review February 17, 2026 09:29
@martintmk
Copy link
Member Author

martintmk commented Feb 17, 2026

Once released, I'll bump all these.

Why not all together?

You mean releasing multiple versions that are interconnected withing a single commit? Will that work?

@sandersaares
Copy link
Member

sandersaares commented Feb 17, 2026 •
edited
Loading

In the same PR (which I guess gets squashed to a single commit, yeah). I have not tried it myself but I do not immediately see why it would not work. Probably it works.

@Vaiz
Copy link
Contributor

Vaiz commented Feb 17, 2026

Once released, I'll bump all these.

Why not all together?

You mean releasing multiple versions that are interconnected withing a single commit? Will that work?

yes, it works
moreover, I think we should prefer doing this instead of publishing crates one by one

Vaiz
Vaiz reviewed Feb 17, 2026
View reviewed changes
crates/seatbelt/Cargo.toml
name = "seatbelt"
description = "Resilience and recovery mechanisms for fallible operations."
version = "0.2.0"
version = "0.3.0"
Copy link
Contributor

@Vaiz Vaiz Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why breaking?

Copy link
Member Author

@martintmk martintmk Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new major version of tick crate

Copy link
Contributor

@Vaiz Vaiz Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add to changelog what was broken and how to migrate to a new version?

Copy link
Contributor

@Vaiz Vaiz Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new major version of tick crate

as long as it not reexported through seatbelt, it should be fine

Copy link
Member Author

@martintmk martintmk Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add to changelog what was broken and how to migrate to a new version?

This information is already contained with the changelog for tick crate. Do you see any reason to duplicate it here?

you don't even have to re-export, exposing it in your public APIs forces you to use that particular major version

@martintmk martintmk changed the title chore: release a new major version of tick crate chore: release a new major version of tick and seatbelt crate Feb 17, 2026
Vaiz
Vaiz approved these changes Feb 17, 2026
View reviewed changes
crates/seatbelt/Cargo.toml
name = "seatbelt"
description = "Resilience and recovery mechanisms for fallible operations."
version = "0.2.0"
version = "0.3.0"
Copy link
Contributor

@Vaiz Vaiz Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new major version of tick crate

as long as it not reexported through seatbelt, it should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vaiz Vaiz Vaiz approved these changes

@sandersaares sandersaares Awaiting requested review from sandersaares

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martintmk @Vaiz @sandersaares