[ms-ifc-sdk] Update to 0.43.5 #48746
Conversation
SunBlack
force-pushed
the
ms-ifc-sdk
branch
3 times, most recently
from
edfe87a to
7a5bf18
Compare
ports/ms-ifc-sdk/portfile.cmake
Outdated
| CONFIG_PATH "${config_path}" | ||
| ) | ||
|
|
||
| # Update this when https://github.com/microsoft/ifc/pull/109 is merged |
There was a problem hiding this comment.
If I understand correctly we need that PR for this new feature to actually do anything. Could you minimize the patch a bit and add it here? Since it's just disabling a whole build system part I think we could add that without the usual 30 day waiting periods.
There was a problem hiding this comment.
The question was: What should happen to the newly added tool? Always copy it via vcpkg_copy_tools or always remove it? That's why I added it as an option, so that you can choose between the two. An alternative would be to add a patch so that it isn't built at all.
There was a problem hiding this comment.
It makes sense to be an option but the option needs to actually be an option; as implemented it seems like the option is not connected because the tool is always built.
There was a problem hiding this comment.
So remove the option and:
Option 1) Always remove the tool, as no one has missed it so far.
Option 2) Always install the tool
Which option do you prefer?
There was a problem hiding this comment.
If we built it we may as well always install it.
BillyONeal
added
the
info:needs-maintainer-attention
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/bin/" | ||
| "${CURRENT_PACKAGES_DIR}/debug/bin/" | ||
| ) |
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Oh I see it's always a static library, OK. Thanks!
2 participants
./vcpkg x-add-version --alland committing the result.Note: The tool was added in microsoft/ifc#59 (0.43.2)